feat(css): add information on scope (at-rule) boundary behavior #37336
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayesian-intelligence
requested review from
estelle
and removed request for
a team
github-actions
bot
added
Content:CSS
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Preview URLs Flaws (48)URL:
(comment last updated: 2024-12-28 19:33:13) |
estelle
reviewed
Dec 28, 2024
| @@ -23,6 +23,8 @@ The `@scope` at-rule contains one or more rulesets (termed **scoped style rules* | |||
| } | |||
| ``` | |||
|
|
|||
| The scope's upper bound is inclusive and its lower bound is exclusive. To change this behavior, you can combine either selector with a universal child selector. For example, `@scope (scope root) to (scope limit > *)` would make both bounds inclusive, `@scope (scope root > *) to (scope limit)` would make both bounds exclusive, while `@scope (scope root > *) to (scope limit > *)` would give an exclusive upper bound and an inclusive lower bound. | |||
|
|
|||
There was a problem hiding this comment.
This is useful information
This would be better placed in the description. This is the syntax section. The child selector portion is useful, but not required syntax. Also, the upper and lower bound is not yet defined, so is hard to parse here, but may be much more understandable if it comes after "The .article-body scope root selector defines the upper bound of the DOM tree scope in which the ruleset will be applied, and the figure scope limit selector defines the lower bound." (emphasis added)
bsmth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more details on @scope boundary behaviour.
Motivation
The default inclusivity / exclusivity behaviour is non-obvious. There is description of it in the MDN page, and no example showing how to invert the selectivity if needed. There is also nothing that explains that a scope limit can be used with an inline @scope.
Additional details
In this revision, the selectivity behaviour is described, and examples given of how to alter the behaviour if needed.
The universal child selector approach is recommended in this WG bug for the lower bound: w3c/csswg-drafts#6577 . It generalises to the upper bound.
Related issues and pull requests